TwelveIterationMods / Balm

Abstraction Layer (but not really)™ for Blay's multiplatform mods
https://mods.twelveiterations.com/mc/balm
Other
24 stars 13 forks source link

Loottable Mixin compatibility #50

Closed someaddons closed 1 year ago

someaddons commented 1 year ago

Minecraft Version

1.19.3

Mod Loader

Fabric

Mod Loader Version

14.14

Mod Version

Any

Describe the Issue

The loot table mixin you're using for your loot modifiers does cancel other mod's calls when they inject in the same place, as setReturnValue also cancels. You probably do not need it at all and could just remove the line, as you're modifying the original list not creating a new one(afaik).

https://github.com/TwelveIterationMods/Balm/blob/f9c766fe3b86fa962cc29bedf6c1a0db25f9d11b/shared/src/main/java/net/blay09/mods/balm/mixin/LootTableMixin.java#L26

Logs

No response

Do you use any performance-enhancing mods (e.g. OptiFine) or custom server distributions (e.g. SpongeForge)?

No response