The default keybind for the "Compress All" function in the Crafting Tweaks mod (Shift + K) does not work when there are no key conflicts. However, if the keybind is changed to any other non-conflicting key combination, it works correctly. Additionally, if the keybinds for "Compress" and "Compress 1" are changed to other keys, the default Shift + K works as intended. It appears that the mod prioritizes the "Compress" action over the "Compress All" action when both could be triggered by the same key combination.
Steps to Reproduce:
Install the Crafting Tweaks mod.
Ensure that the default keybind for "Compress All" is set to Shift + K and there are no key conflicts.
Attempt to use the "Compress All" function with Shift + K.
Change the "Compress All" keybind to any other non-conflicting key combination.
Attempt to use the "Compress All" function with the new keybind.
Change the keybinds for "Compress" and "Compress 1" to different keys.
Attempt to use the "Compress All" function with the default Shift + K.
Expected Behavior:
The "Compress All" function should work with the default keybind (Shift + K) when there are no key conflicts.
Actual Behavior:
The "Compress All" function does not work with the default keybind (Shift + K). It only works when the keybind is changed to another non-conflicting key combination or when the keybinds for "Compress" and "Compress 1" are changed.
Code Analysis:
While reviewing the code, the function getCompressTypeForKey seems to prioritize the "Compress" action over the "Compress All" action
The issue may stem from the order of checks, as the "Compress" actions are checked before the "Compress All" action. This could lead to the "Compress" action being triggered instead of "Compress All" when using the default keybind.
https://github.com/TwelveIterationMods/CraftingTweaks/commit/13db296784c9f166d446226a409168d1219d5c54
This issue seems to be a recent development, as earlier playthroughs by YouTubers like ChosenArchitect in his ATM9 to the Sky series showed the default keybinds working correctly.
Note: My code analysis is from the perspective of a c# unity dev with little to no Java and no Minecraft Mod experience
Logs
No response
Do you use any performance-enhancing mods (e.g. OptiFine) or custom server distributions (e.g. SpongeForge)?
Minecraft Version
1.20.1 (LTS)
Mod Loader
Forge
Mod Loader Version
47.2.20
Mod Version
18.2.4
Balm Version
7.3.6-all
Describe the Issue
Summary:
The default keybind for the "Compress All" function in the Crafting Tweaks mod (Shift + K) does not work when there are no key conflicts. However, if the keybind is changed to any other non-conflicting key combination, it works correctly. Additionally, if the keybinds for "Compress" and "Compress 1" are changed to other keys, the default Shift + K works as intended. It appears that the mod prioritizes the "Compress" action over the "Compress All" action when both could be triggered by the same key combination.
Steps to Reproduce:
Install the Crafting Tweaks mod. Ensure that the default keybind for "Compress All" is set to Shift + K and there are no key conflicts. Attempt to use the "Compress All" function with Shift + K. Change the "Compress All" keybind to any other non-conflicting key combination. Attempt to use the "Compress All" function with the new keybind. Change the keybinds for "Compress" and "Compress 1" to different keys. Attempt to use the "Compress All" function with the default Shift + K.
Expected Behavior:
The "Compress All" function should work with the default keybind (Shift + K) when there are no key conflicts.
Actual Behavior:
The "Compress All" function does not work with the default keybind (Shift + K). It only works when the keybind is changed to another non-conflicting key combination or when the keybinds for "Compress" and "Compress 1" are changed.
Code Analysis:
While reviewing the code, the function getCompressTypeForKey seems to prioritize the "Compress" action over the "Compress All" action The issue may stem from the order of checks, as the "Compress" actions are checked before the "Compress All" action. This could lead to the "Compress" action being triggered instead of "Compress All" when using the default keybind. https://github.com/TwelveIterationMods/CraftingTweaks/commit/13db296784c9f166d446226a409168d1219d5c54 This issue seems to be a recent development, as earlier playthroughs by YouTubers like ChosenArchitect in his ATM9 to the Sky series showed the default keybinds working correctly.
Note: My code analysis is from the perspective of a c# unity dev with little to no Java and no Minecraft Mod experience
Logs
No response
Do you use any performance-enhancing mods (e.g. OptiFine) or custom server distributions (e.g. SpongeForge)?
No response