search

TwelveIterationMods / NetherPortalFix

Minecraft Mod. Ensures correct destinations when travelling back and forth through Nether Portals in Multiplayer.
https://mods.twelveiterations.com/mc/netherportalfix/
Other
18 stars 11 forks source link

Use ITeleporter #28

Closed LatvianModder closed 4 years ago

LatvianModder commented 5 years ago

https://github.com/blay09/NetherPortalFix/blob/1.12/src/main/java/net/blay09/mods/netherportalfix/NetherPortalFix.java#L145-L195

These methods are old, Forge has added ITeleporter and fixed issues with cross-dimension teleportation when using entity.changeDimension(int dimension, ITeleporter); You can see https://github.com/LatvianModder/FTBLib/blob/master/src/main/java/com/feed_the_beast/ftblib/lib/math/TeleporterDimPos.java#L81 for example. Just came here after I got reported an issue with this mod and old methods may be the cause. (https://github.com/LatvianModder/FTBUtilities/issues/577#issuecomment-440283753)

BlayTheNinth commented 4 years ago

Fixed in 1.14+ by using the new ServerPlayerEntity.teleport() method.