TwelveIterationMods / Waystones

Minecraft Mod. Adds waystones you can teleport to after they've been activated.
https://mods.twelveiterations.com/mc/waystones/
Other
275 stars 110 forks source link

Waystones can prevent generation of structures with waystones #865

Closed johalun closed 2 months ago

johalun commented 2 months ago

Minecraft Version

1.20.1 (LTS)

Mod Loader

Forge

Mod Loader Version

47.2.32

Mod Version

14.1.3

Balm Version

7.3.6

Describe the Issue

The issue is discussed in https://github.com/celsiusqc/TowersOfTheWildModded/issues/17

Waystones can sometimes (seemingly randomly) prevent the top of the towers in Towers of The Wild - modded to generate. The top part containing the waystone is a separate structure from the tower part. This only happens with Waystones mod enabled.

After some research by SettingDust, it seems there's some issue in the waystones code causing this. They say in the ticket linked above:

https://github.com/TwelveIterationMods/Waystones/blob/1.20.1/shared/src/main/java/net/blay09/mods/waystones/mixin/SinglePoolElementMixin.java#L51

after research. Waystone will block the generating since https://github.com/TwelveIterationMods/Waystones/blob/1.20.1/shared/src/main/java/net/blay09/mods/waystones/mixin/SinglePoolElementMixin.java#L34 the path containing the string.

It's for only one in every village from the comment. But the logic is terrible

Need to blocking the mixin injecting the wayston into village with https://github.com/Bawnorton/MixinSquared And reinject the waystone element into the pool with https://modrinth.com/mod/lithostitched. Maybe I'll create a standalone mod for that XD

Logs

No response

Do you use any performance-enhancing mods (e.g. OptiFine) or custom server distributions (e.g. SpongeForge)?

No response