TwelveIterationMods / Waystones

Minecraft Mod. Adds waystones you can teleport to after they've been activated.
https://mods.twelveiterations.com/mc/waystones/
Other
275 stars 110 forks source link

Store whether a waystone is currently in-world or not #893

Open samrego opened 2 weeks ago

samrego commented 2 weeks ago

~ IMPORTANT SECURITY NOTICE ~

Minecraft Version

1.20.1 (LTS)

Mod Loader

Fabric

Mod Loader Version

0.16.3

Mod Version

14.1.5

Balm Version

7.3.9

Describe the Issue

Very niche issue. Waystones that are mined with silk touch stay in the waypoints.dat file even if the item no longer exists.

This is relevant to me (and gave me a headache) because I wanted to create a map of all the waystones on a server of mine. I can imagine that this might also cause trouble for some in-game map mods but I haven't tested that, sorry.

I don't expect there to be a nice and clean solution to this, but maybe some of the most prevalent cases of item loss - despawning, falling in lava and falling into the void - can be tackled without too much hassle (if this is deemed important enough).

Logs

No response

Do you use any performance-enhancing mods (e.g. OptiFine) or custom server distributions (e.g. SpongeForge)?

Sodium

BlayTheNinth commented 2 weeks ago

It's impossible to reliably track the disappearance of an item. The best I could do is add another flag to waystones.dat that indicates whether the waystone is currently in-world or not.

samrego commented 2 weeks ago

The best I could do is add another flag to waystones.dat that indicates whether the waystone is currently in-world or not.

That would also be amazing!