search

TwentyTwoHW / portal-software

Firmware and supporting libraries for the Portal Hardware Wallet
GNU General Public License v3.0
36 stars 6 forks source link

Add "show seed" option #26

Open storopoli opened 2 months ago

storopoli commented 2 months ago

Most HW wallets let you see your seed at any future convenient time.

storopoli commented 2 months ago

Or maybe at least the xpriv in https://github.com/TwentyTwoHW/portal-software/blob/c5a630090d53164d1d4b13fb03456519b1e113af/firmware/src/handlers/mod.rs#L41-L45

Since the Mnemonic is not stored and used directly in display_mnemonic https://github.com/TwentyTwoHW/portal-software/blob/c5a630090d53164d1d4b13fb03456519b1e113af/firmware/src/handlers/init.rs#L508-L511

xrviv commented 2 months ago

Hi! Danny here from @walletscrutiny. I'd like to confirm if I understood this issue correctly, the device has the ability to generate the seed phrase without it being connected to the app/phone via NFC, but does not display the mnemonics on the device?

storopoli commented 2 months ago

It does but only once. That's why

any future convenient time

xrviv commented 2 months ago

Noted with thanks.