Twentysix26 / 26-Cogs

General purpose cogs for Red (v2)
GNU General Public License v3.0
26 stars 43 forks source link

[trigger] Remove redundant check for self-authorship #10

Closed calebj closed 7 years ago

calebj commented 7 years ago

bot.user_allowed(message) already does this

Twentysix26 commented 7 years ago

As I see in user_allowed this might cause issues to self bots (although they really should not use this cog). Closing, I doubt this simple check has any meaningful impact on performances anyway

skeith commented 7 years ago

Noooooo~

*screaming intensifies

calebj commented 7 years ago

I prevented selfbot-triggering with https://github.com/calebj/Red-DiscordBot/blob/selfbot/red_self.py#L173, and it's reliable. Only the user would be able to trigger their selfbot.

Would be neater if it had the option to edit or delete the original message in this case, too.

skeith commented 7 years ago

I wanted a toggle on trigger for selfbot. I sometimes want it to trigger on other user messages

calebj commented 7 years ago

I sometimes want it to trigger on other user messages

Er, no. That's against Discord ToS for userbots, and I won't support it. Feel free to write it yourself, though.

skeith commented 7 years ago

Then I assume you wil be removing your status(away) cog from selfbot distribution since it was basically similar

calebj commented 7 years ago

What distribution again?

skeith commented 7 years ago

If i am not mistaken. Cloning the selfbot from your fork (branch selfbot) comes with a cog called status (for away status)

calebj commented 7 years ago

It does not, and never did. Check for yourself.

skeith commented 7 years ago

God. I am mixing something up. My apologies