Big Rift update

[Zephyrkul]

I played around with Rift and added a few improvements:

• Due to the addition of three more commands, [p]rift is now a group command with [p]rift open opening a rift instead of [p]riftopen.
• New [p]rift search command, which searches for rifts with the specified parameters.
• Rift can now set a User as a destination, which will set the user's direct message channel with the bot as the channel destination.
  • Refactored channel search logic so this works. Name, ID, and mentions for both users and channels are accepted.
• Added some security features
  • Rift notifies the destination when a rift is opened to it. Owner can disable this globally with [p]rift notify.
  • Rift always notifies the destination when the destination is a private channel, regardless of the above setting. Private channel destinations may also be exited from both source and destination. The source is notified if the destination closed the rift.
  • New [p]rift close command, available to admins, manage_channel, and DMs. This closes all rifts whose destination is the channel the command is used in. Source channels are notified of this.
  • New [p]rift blacklist command, with the same check as close. This closes rifts as above and also will block future rifts from being opened to the current channel. Removing works similarly.
• Various bugfixes
  • If an author opens up multiple rifts, the open_rifts storing works correctly (previously it would only store the most recently opened one).
  • If an already open rift is opened again, the bot will not open the duplicate rift instead of just opening it again.
  • If multiple rifts are open that have the same source and destination (only possible with two different authors), the bot will send the return message only once instead of once per rift.
  • A rift will not be opened if its source and destination are the same channel.
  • The bot will not send the message to the destination channel if the message starts with the bot's prefix(es). This allows for multiple rifts with the same source without sending the subsequent [p]rift open commands to the previous rifts. (Previously I had it set where rift accepted multiple arguments, but I decided this approach was better.)
  • Commands from the destination are still relayed to the source.
  • Not sure if this was a bug with my fork or the base, but on unloading the cog all rifts are closed.
• Changed info.json to give the proper [p]rift open command, and also sneakily gave myself co-author credit.

[Zephyrkul]

(though at the moment the task remains open until the next message from the author or until the next restart).

Fixed this. All rift logic is moved to on_message; [p]rift open simply adds another rift to the set of open rifts for on_message to process.

[Zephyrkul]

Added [p]rift blacklist for more security.

[Zephyrkul]

I added support for edits and deletes passing through rifts, because I completely forgot that was a feature I always wanted added to rifts.

[Zephyrkul]

One more security feature that's rather commonly requested: The bot will not open rifts to channels or users that the author can't see (bot owner bypasses this requirement). The bot will also not open rifts to channels the bot itself can't see or send messages to. Also, small bugfix, the bot won't open a rift to its own DMs.

[Twentysix26]

I swear I'll look at this one day 😅

[Zephyrkul]

No worries, there's actually a small bugfix and feature request I need to implement anyway.

[skeith]

@zephyrkul is the new rift locked or just like old rift, available for everyone? if yes, is the notify has option to DM the admin/owner whenever a new rift opened?

[Zephyrkul]

New rift is open to everyone, but you can't open rifts to channels you don't have access to. Notify simply tells the channel that a rift is opened to that the command author has opened a rift to that channel.

I'm thinking I may get rid of it. I originally put it in so people would know when secret channels are being accessed, but that's not as much of a problem anymore (though the DM notification would remain).

[skeith]

I am thinking the notification should also notify adminrole or modrole or owner, since we might want to monitor rift usage

[Zephyrkul]

Hmm... okay, I'll overhaul notify so it can be set up to notify a server channel and DM the bot owner, with a configurable setting, along with the other feature request and bugfix.

[skeith]

Why closed?

[Zephyrkul]

Generally my understanding is that v2 cogs etc. won't be actively developed for anymore, so I closed this and created a new fork that I can mess around in myself (you'll note I messed around before closing the PR, hence the trigger changes listed above). I still have all the code if 26 would like me to re-open another rift PR.

[skeith]

That's sad.

[Zephyrkul]

My fork is still here if you'd like to add the repo under a different name: https://github.com/zephyrkul/26-Cogs