search

Twentysix26 / Red-Docs

Docs for Red - Discord bot
8 stars 16 forks source link

RiceCogs #64

Closed QingyuChai closed 7 years ago

QingyuChai commented 7 years ago

Hello! I'd like to apply to have my repo become beta.

List: [beta] Repository name: RiceCogs Author: FwiedWice Description: Random cogs ranging from server management to utility to killing people.

https://github.com/QingyuChai/RiceCogs

Twentysix26 commented 7 years ago

rice cog: Custom stuff that doesn't belong in a public repo

This... just no, you shouldn't depend on the user to start a loop that makes your cog function. Even if you want to make it optional, it should be designed better, at the moment it won't even stop if the cog gets unloaded.

Your code cog could be one liners or just a single command if you use the box function in utils/chat_formatting

QingyuChai commented 7 years ago

@Twentysix26 sorry, I didn't see your comment until now! I'll find a way to fix the birthday loop.

Kowlin commented 7 years ago

Spotted this part when browsing your repo. You might want to grab the server prefix. https://github.com/QingyuChai/RiceCogs/blob/master/birthday/birthday.py#L96

QingyuChai commented 7 years ago

@Kowlin thank you, Kowlin! I will be changing this for all of my cogs!

Chovin commented 7 years ago

@Kowlin @QingyuChai can you explain to me why you'd want to do that? ctx.prefix is the prefix used to call the command. I see no problem with using that to tell people what to type next

QingyuChai commented 7 years ago

That's what I just changed @Chovin

Chovin commented 7 years ago

ahh.. see, if this was a PR, I'd be able to see that :P 😭

QingyuChai commented 7 years ago

@Twentysix26 Hey! I removed the rice cog from the repo, and for birthday I decided that the user would still have to start the loop if he wants it. However, the loop now stops when the cog is unloaded and the owner cannot start multiple loops. Also, for the code cog, I did what you recommended, and it works perfectly! Thanks!

QingyuChai commented 7 years ago

I haven't really been maintaining RiceCogs as well as I should have, and I am not satisfied with the quality of what I have made. I will be closing this issue for now, and will reopen it once I created better content.