search

Twentysix26 / x26-Cogs

General purpose cogs for Red V3
GNU General Public License v3.0
41 stars 30 forks source link

[Bug] message-contains-media condition and certain Tenor URLs #85

Open EternalllZM opened 3 months ago

EternalllZM commented 3 months ago

Cog

Describe the bug Some tenor GIFs like to format themselves in an odd way which involves excluding a file extension that the message-contains-media condition looks for. I'm not sure if there's any way to improve the identification of GIFs moreso than the current regex used. However, this essentially forces you to utilize different conditions such as message-contains-url as a catch-all to avoid false negatives.

To Reproduce Steps to reproduce the behavior:

  1. Create a rule with the condition message-contains-media
  2. Post a tenor gif that excludes a file extension (https://tenor.com/view/sopranos-gabagool-tony-therapy-gif-26084338)
  3. Notice that the condition is considered not true, due to it not containing an extension .gif.
  4. No execution of actions take place where it was expected to do so.

Expected behavior Expected behavior would be that the message-contains-media condition is true for containing a GIF.