search

TwiDev / SpectralDamage

Spectral Damage is a plugin that allows you to display in the form of an animated hologram the damage that a player inflicts on a mob or another player
https://www.spigotmc.org/resources/110551
MIT License
8 stars 2 forks source link

set showToDamagerOnly to false, all the armor stands will become server-side? #24

Open WMGameLive opened 2 months ago

WMGameLive commented 2 months ago

I thought this plugin was using packets, so it would be client-side only. But if I set showToDamagerOnly to false, it becomes server-side, and there’s a high chance the armor stands won’t despawn. Now my server has a ton of armor stands that won’t despawn, and I have to use the /kill command to clear them.

TwiDev commented 2 months ago

Hello,

Thanks for the comment !, to better understand your problem I need to know which version of the plugin you are currently using, you can find out with the /spectraldamage command.

Sincerely

TwiDev commented 2 months ago

And the minecraft version of the server

Yes, when damage indicators are visible to all other players on the server, the hologram becomes server side for performance issues. There are plans to add a new configuration for this in the next update and change the way holograms are spawned.

WMGameLive commented 2 months ago

And the minecraft version of the server

Plugin is 2.6.6, server is 1.20.2 and 1.21, both server have same issue.

Yes, when damage indicators are visible to all other players on the server, the hologram becomes server side for performance issues. There are plans to add a new configuration for this in the next update and change the way holograms are spawned.

You just claim it’s only packets and client-side on your plugin page without mentioning this anywhere.

TwiDev commented 2 months ago

Hello,

I carried out several tests on versions 1.21.1 of paper and spigot, I noticed no problem with the latest version 2.6.6 of the plugin, the holograms worked well. To resolve your problem, however, I need more information, what version of Minecraft you are on, spigot, paper, snapshot, ... You specified version 1.21 which is currently entirely replaced by version 1.21. 1 I therefore advise you to update it. The despawn of holograms may be due to your Minecraft instance or other external plugins. I therefore advise you to remove the plugins one by one to test.

Furthermore, I did not specify that the hologram visible to all players was not client-side, because the primary goal of sending packets to a single client is that only one player can see the modification in game (what the plugin does by default), so if we have to make a hologram appear to all the players in a certain radius and therefore send a packet to each player we are doing exactly the work of Minecraft and consequently we are reinventing the wheel since that is exactly what the game does by default . But as I specified before, i planned to add a configuration to make the holograms completely client side in order to use the falling animation with them.

Sincerely

TwiDev commented 2 months ago

Would it be possible to have video/image extracts to be able to see if it's a hologram that disappears / if the text disappears too, etc, please ?

WMGameLive commented 2 months ago

When the armor stand is still there and the chunk gets unloaded or the server shuts down (or maybe more reason idk), the armor stand gets stuck forever. But that’s not the main point, I just want it to stay client-side even if showToDamagerOnly is set to false. If it is client-side, all issues will be solved.