fix: Logo on Login screen

TwiN / gatus

⛑ Automated developer-oriented status page

https://gatus.io

Apache License 2.0

6.12k stars 408 forks source link

fix: Logo on Login screen #834

Open praveen-livspace opened 1 month ago

praveen-livspace commented 1 month ago

Summary

Logo on the login screen is hardcoded. The proposed change uses the configured logo if available.

Checklist

[ ] Tested and/or added tests to validate that the changes work as intended, if applicable.
[ ] Updated documentation in README.md, if applicable.

TwiN commented 1 month ago

Does that really make sense though? I understand wanting to have to user logo on the page, but if there's an authentication page, wouldn't users want to know what they're authenticating to?

I'd be willing to meet in the middle and have some kind of <custom logo> | <Gatus' logo> design, but I feel just having the custom logo may be a bit confusing for the end user