TwidereProject / Twidere-Android

http://twidere.com
2.76k stars 377 forks source link

Can't display more than 20 statuses on Friendica user's timeline #1042

Open Rudloff opened 6 years ago

Rudloff commented 6 years ago

This happens when I'm browsing my own Friendica user's timeline.

Expected behavior

20 posts are displayed and when I scroll to the bottom more are displayed.

Actual behavior

20 posts are displayed and when I scroll to the bottom no new posts are displayed.

Steps to reproduce

  1. Connect with a Friendica account.
  2. Open your own's user timeline.
  3. Browse to the bottom.

Extra info

Android version: 6.0.1

Network type:

App version: 3.7.3

Build variant:

Micro-blogging service:

App settings:

At first it was because Friendica did not support the max_id parameter but this has now been implemented (https://github.com/friendica/friendica/pull/4080).

When I open the timeline, statuses are loaded from https://social.rudloff.pro/api/statuses/user_timeline.json?exclude_replies=false&count=20&include_blocked_by=true&include_rts=true&include_blocking=true&user_id=13:

[
  {
    "text": "Je d\u00e9couvre https:\/\/anbox.io\/ qui permet de faire tourner des applications Android sur Linux et a l'air tr\u00e8s cool. Dommage que l'installation soit aussi lourde pour l'instant \ud83d\ude1e",
    "truncated": false,
    "created_at": "Sat Dec 16 15:15:45 +0000 2017",
    "in_reply_to_status_id": null,
    "in_reply_to_status_id_str": null,
    "source": "Twidere (Friendica)",
    "id": 359773,
    "id_str": "359773",
    "in_reply_to_user_id": null,
    "in_reply_to_user_id_str": null,
    "in_reply_to_screen_name": null,
    "geo": null,
    "favorited": false,
    "user": {
      "id": 13,
      "id_str": "13",
      "name": "Pierre Rudloff",
      "screen_name": "rudloff",
      "location": "",
      "description": "",
      "profile_image_url": "https:\/\/social.rudloff.pro\/photo\/524d58171fafc86b4121411e2283a062-6.jpg",
      "profile_image_url_https": "https:\/\/social.rudloff.pro\/photo\/524d58171fafc86b4121411e2283a062-6.jpg",
      "url": "https:\/\/social.rudloff.pro\/profile\/rudloff",
      "protected": false,
      "followers_count": 0,
      "friends_count": 0,
      "listed_count": 0,
      "created_at": "Fri Apr 07 19:06:23 +0000 2017",
      "favourites_count": 0,
      "utc_offset": "0",
      "time_zone": "UTC",
      "geo_enabled": false,
      "verified": true,
      "statuses_count": 0,
      "lang": "",
      "contributors_enabled": false,
      "is_translator": false,
      "is_translation_enabled": false,
      "following": false,
      "follow_request_sent": false,
      "statusnet_blocking": false,
      "notifications": false,
      "statusnet_profile_url": "https:\/\/social.rudloff.pro\/profile\/rudloff",
      "cid": 1,
      "network": "dfrn"
    },
    "friendica_owner": {
      "id": 13,
      "id_str": "13",
      "name": "Pierre Rudloff",
      "screen_name": "rudloff",
      "location": "",
      "description": "",
      "profile_image_url": "https:\/\/social.rudloff.pro\/photo\/524d58171fafc86b4121411e2283a062-6.jpg",
      "profile_image_url_https": "https:\/\/social.rudloff.pro\/photo\/524d58171fafc86b4121411e2283a062-6.jpg",
      "url": "https:\/\/social.rudloff.pro\/profile\/rudloff",
      "protected": false,
      "followers_count": 0,
      "friends_count": 0,
      "listed_count": 0,
      "created_at": "Fri Apr 07 19:06:23 +0000 2017",
      "favourites_count": 0,
      "utc_offset": "0",
      "time_zone": "UTC",
      "geo_enabled": false,
      "verified": true,
      "statuses_count": 0,
      "lang": "",
      "contributors_enabled": false,
      "is_translator": false,
      "is_translation_enabled": false,
      "following": false,
      "follow_request_sent": false,
      "statusnet_blocking": false,
      "notifications": false,
      "statusnet_profile_url": "https:\/\/social.rudloff.pro\/profile\/rudloff",
      "uid": 1,
      "cid": 1,
      "self": "1",
      "network": "dfrn"
    },
    "statusnet_html": "Je d&eacute;couvre <a href=\"https:\/\/anbox.io\/\" target=\"_blank\">https:\/\/anbox.io\/<\/a> qui permet de faire tourner des applications Android sur Linux et a l'air tr&egrave;s cool. Dommage que l'installation soit aussi lourde pour l'instant &#128542;",
    "statusnet_conversation_id": "359773",
    "friendica_activities": {
      "like": [
        {
          "id": "7186",
          "id_str": "7186",
          "name": "PE",
          "screen_name": "PERaspberry",
          "location": "Mastodon",
          "description": "Lyc\u00e9en et libriste mod\u00e9r\u00e9 ;-)\n\u271d\ufe0f=\u2764\ufe0f",
          "profile_image_url": "https:\/\/social.rudloff.pro\/photo\/8014d2a4185a16d19043e22f108578a7-6.png?ts=1513437390",
          "profile_image_url_https": "https:\/\/social.rudloff.pro\/photo\/8014d2a4185a16d19043e22f108578a7-6.png?ts=1513437390",
          "url": "https:\/\/framapiaf.org\/@PERaspberry",
          "protected": false,
          "followers_count": 0,
          "friends_count": 0,
          "listed_count": 0,
          "created_at": "Sat Dec 16 15:16:29 +0000 2017",
          "favourites_count": 0,
          "utc_offset": 0,
          "time_zone": "UTC",
          "geo_enabled": false,
          "verified": false,
          "statuses_count": 0,
          "lang": "",
          "contributors_enabled": false,
          "is_translator": false,
          "is_translation_enabled": false,
          "following": false,
          "follow_request_sent": false,
          "statusnet_blocking": false,
          "notifications": false,
          "statusnet_profile_url": "https:\/\/framapiaf.org\/@PERaspberry",
          "uid": 0,
          "cid": 0,
          "self": 0,
          "network": "stat"
        },
        {
          "id": 3391,
          "id_str": "3391",
          "name": "Vincent-Xavier",
          "screen_name": "vincentxavier",
          "location": "Mastodon",
          "description": null,
          "profile_image_url": "https:\/\/social.rudloff.pro\/photo\/17c7ed9e0085316e266c0f606983e35b-6.png?ts=1513437424",
          "profile_image_url_https": "https:\/\/social.rudloff.pro\/photo\/17c7ed9e0085316e266c0f606983e35b-6.png?ts=1513437424",
          "url": "https:\/\/mastodon.etalab.gouv.fr\/@vincentxavier",
          "protected": false,
          "followers_count": 0,
          "friends_count": 0,
          "listed_count": 0,
          "created_at": "Sun Jun 25 17:47:51 +0000 2017",
          "favourites_count": 0,
          "utc_offset": "0",
          "time_zone": "UTC",
          "geo_enabled": false,
          "verified": true,
          "statuses_count": 0,
          "lang": "",
          "contributors_enabled": false,
          "is_translator": false,
          "is_translation_enabled": false,
          "following": true,
          "follow_request_sent": false,
          "statusnet_blocking": false,
          "notifications": false,
          "statusnet_profile_url": "https:\/\/mastodon.etalab.gouv.fr\/@vincentxavier",
          "uid": 1,
          "cid": 4611,
          "self": "0",
          "network": "stat"
        }
      ],
      "dislike": [],
      "attendyes": [],
      "attendno": [],
      "attendmaybe": []
    },
    "attachments": false
  }
  // Other 19 items are removed
]

Then when I scroll to the bottom it loads https://social.rudloff.pro/api/statuses/user_timeline.json?exclude_replies=false&count=20&include_blocked_by=true&include_rts=true&include_blocking=true&user_id=13&max_id=195132:

[
  {
    "text": "Wouwiwooouuuh \ud83e\udd13",
    "truncated": false,
    "created_at": "Sat Jul 22 19:19:32 +0000 2017",
    "in_reply_to_status_id": null,
    "in_reply_to_status_id_str": null,
    "source": "Twidere (Friendica)",
    "id": 195132,
    "id_str": "195132",
    "in_reply_to_user_id": null,
    "in_reply_to_user_id_str": null,
    "in_reply_to_screen_name": null,
    "geo": null,
    "favorited": false,
    "user": {
      "id": 13,
      "id_str": "13",
      "name": "Pierre Rudloff",
      "screen_name": "rudloff",
      "location": "",
      "description": "",
      "profile_image_url": "https:\/\/social.rudloff.pro\/photo\/524d58171fafc86b4121411e2283a062-6.jpg",
      "profile_image_url_https": "https:\/\/social.rudloff.pro\/photo\/524d58171fafc86b4121411e2283a062-6.jpg",
      "url": "https:\/\/social.rudloff.pro\/profile\/rudloff",
      "protected": false,
      "followers_count": 0,
      "friends_count": 0,
      "listed_count": 0,
      "created_at": "Fri Apr 07 19:06:23 +0000 2017",
      "favourites_count": 0,
      "utc_offset": "0",
      "time_zone": "UTC",
      "geo_enabled": false,
      "verified": true,
      "statuses_count": 0,
      "lang": "",
      "contributors_enabled": false,
      "is_translator": false,
      "is_translation_enabled": false,
      "following": false,
      "follow_request_sent": false,
      "statusnet_blocking": false,
      "notifications": false,
      "statusnet_profile_url": "https:\/\/social.rudloff.pro\/profile\/rudloff",
      "cid": 1,
      "network": "dfrn"
    },
    "friendica_owner": {
      "id": 13,
      "id_str": "13",
      "name": "Pierre Rudloff",
      "screen_name": "rudloff",
      "location": "",
      "description": "",
      "profile_image_url": "https:\/\/social.rudloff.pro\/photo\/524d58171fafc86b4121411e2283a062-6.jpg",
      "profile_image_url_https": "https:\/\/social.rudloff.pro\/photo\/524d58171fafc86b4121411e2283a062-6.jpg",
      "url": "https:\/\/social.rudloff.pro\/profile\/rudloff",
      "protected": false,
      "followers_count": 0,
      "friends_count": 0,
      "listed_count": 0,
      "created_at": "Fri Apr 07 19:06:23 +0000 2017",
      "favourites_count": 0,
      "utc_offset": "0",
      "time_zone": "UTC",
      "geo_enabled": false,
      "verified": true,
      "statuses_count": 0,
      "lang": "",
      "contributors_enabled": false,
      "is_translator": false,
      "is_translation_enabled": false,
      "following": false,
      "follow_request_sent": false,
      "statusnet_blocking": false,
      "notifications": false,
      "statusnet_profile_url": "https:\/\/social.rudloff.pro\/profile\/rudloff",
      "uid": 1,
      "cid": 1,
      "self": "1",
      "network": "dfrn"
    },
    "statusnet_html": "Wouwiwooouuuh &#129299;<br><a href=\"https:\/\/social.rudloff.pro\/photos\/rudloff\/image\/112c5ad7f0974ce42525144f28f5ef44\/?zrl=https%3A%2F%2Fsocial.rudloff.pro%2Fprofile%2Frudloff\" target=\"_blank\"><img src=\"https:\/\/social.rudloff.pro\/photo\/112c5ad7f0974ce42525144f28f5ef44-1.jpg\" alt=\"Image\/photo\"><\/a>",
    "statusnet_conversation_id": "195132",
    "friendica_activities": {
      "like": [],
      "dislike": [],
      "attendyes": [],
      "attendno": [],
      "attendmaybe": []
    },
    "attachments": [
      {
        "url": "https:\/\/social.rudloff.pro\/photo\/112c5ad7f0974ce42525144f28f5ef44-1.jpg",
        "mimetype": "image\/jpeg",
        "size": 38325
      }
    ]
  }
  // Other 19 items are removed
]
annando commented 6 years ago

Mostly when something doesn't work with Twidere and Friendica, you should blame Friendica ;-)

Although Friendica does support most API calls, we aren't 100% complete, neither in the commands nor in the parameters.

mariotaku commented 6 years ago

@annando While this isn't Twidere's problem, there are something Twidere should improve indeed. As you can see Twidere tries to send parameters that is unused other than Twitter.

Tedko commented 4 years ago

@annando @Rudloff seems like this issue is fixed in 4.1.1. Maybe you can try through GNU social Api. Not sure if we can still reproduce this.

Also seems Fedilab (Android) is removed from Gitlab?

Rudloff commented 4 years ago

I can still reproduce with Twidere 4.1.0 and Friendica 2019.12.

Tedko commented 4 years ago

I can still reproduce with Twidere 4.1.0 and Friendica 2019.12.

Thanks for reporting. Will take a deeper look.