TwidereProject / Twidere-Android

http://twidere.com
2.76k stars 377 forks source link

Auto theme switching not synced to local time #1195

Open nevillepark opened 5 years ago

nevillepark commented 5 years ago

Expected behavior

Theme switches from light to dark at sunset, and back again at sunrise, as determined by day/night times in the user's location.

Actual behavior

Theme switches from light to dark at 10 PM and switches back at 6 AM, regardless of actual sunrise/sunset times.

Steps to reproduce

In Twidere theme settings, tap Theme, and select "Auto". Change phone system time to 10 PM and open Twidere again. Change phone system time to 6 AM and open Twidere again.

Edit: I think this is what's needed to implement it properly?

Extra info

Android version: 9

Network type:

App version: 3.7.5

Build variant:

Micro-blogging service:

App settings:

Tedko commented 4 years ago

Dark Theme request

weiss commented 4 years ago

I think it would be nice if the light/dark theme was auto-selected depending on the system-wide setting (by default) on Android 10+, as suggested by Google these days. This way, it would be left to the OS configuration whether auto-switching to dark mode is done based on time or based on other criteria (such as low battery), and the theme would be consistent with other apps behaving that way.