Real size media works for only one column

TwidereProject / Twidere-Android

http://twidere.com

2.75k stars 377 forks source link

Real size media works for only one column #1321

Open Geobert opened 4 years ago

Geobert commented 4 years ago

Expected behavior

When selecting "real size" for media preview, it should apply to all columns

Actual behavior

It only works for the 1st column

Steps to reproduce

Select "Real size" in preview options
restart the app
check pictures preview are not full size in other columns

Extra info

Android version: 10

Network type:

[x] Cellular
[x] Wi-Fi

App version: 4.1.3

Build variant:

[x] Google
[ ] F-Droid

Micro-blogging service:

[x] Twitter
[ ] Fanfou
[ ] GNU Social / StatusNet
[x] Mastodon

App settings:

[ ] Custom API
[ ] Custom consumer key/secrets
[ ] Official keys
[ ] Using Thumbor
[ ] Connected through proxy
[x] Media preview enabled

Geobert commented 4 years ago

After more testing, it seems to impact only Mastodon columns

Tlaster commented 4 years ago

Just wondering if all columns show as real size, how will they be displayed?

Geobert commented 4 years ago

What do you mean?

Tlaster commented 4 years ago

Currently, if there're more than one media, the media will be displayed as a normal grid view no matter the setting is, that why real size setting only works for one media.
If all media should be displayed as real size, are they should be a staggered grid or other layouts? And by the way, I've just fixed the real size setting not working for mastodon by d88e7f331ab19fd14ea0b7595bed8409fc278876

Geobert commented 4 years ago

I'm using Twidere on a phone in portrait mode, so I'm seeing one column at a time :) thanks for the fix!

EDIT: Oh, you're talking about this media view. In this case I think real size view doesn't make sense, does it?

Tlaster commented 4 years ago

Yeah, I think so.

Geobert commented 4 years ago

And the setting is about the media preview only, so your fix should be enough, I'll close this when the fix is released