search

TwidereProject / Twidere-Android

http://twidere.com
2.75k stars 377 forks source link

[Feature Request] Support for image alt text #713

Open orithena opened 7 years ago

orithena commented 7 years ago

Last year, Twitter added support for "image alt text", a way to describe the contents of an attached image for the visually impaired in 420 characters or less.

The REST API changes are summarized here: https://blog.twitter.com/2016/alt-text-support-for-twitter-cards-and-the-rest-api

This feature request consists of two parts:

1) Displaying the image alt text in the "load media" button (same text size as the tweet), since it already came along with the tweet in extended_entities:media[n]:ext_alt_text. This would not only help the visually impaired, but might also give the data volume challenged a hint about what to expect from the image before loading it.

2) Add support for adding an image alt text along with an image attachment in a way that encourages doing so. E.g. when adding an image to a tweet, show a dialog asking for an image description.

mariotaku commented 7 years ago
  1. I've added alt_text to each media image's content description, making screen reader apps like TalkBack can read it for visually impaired people. For UI design perspective, I don't think it's a very good idea to make alt text visible to everyone.
  2. This is located in that edit icon in compose dialog, you can click and edit alt text. image
mariotaku commented 7 years ago

I'll add alt_text to "load media" button's contentDescription.

orithena commented 7 years ago
  1. UI design... well okay, I can halfway agree on that. It might be hard to integrate, design-wise. Still, I'd love to see the alt text somewhere when the media itself isn't loaded yet; if only it is to encourage using that feature. If people without screen readers don't see these descriptions, they have very little incentive to actually provide descriptions themselves. Also, it would help people with little bandwidth to spare (like me) to decide whether to load the media or not.

Here's an idea: Could you split the "load media" button into "load media" and "show alt text", maybe the latter as an icon (e.g. a speech balloon, U+1F4AC), popping up a modal dialog containing the alt text? I'd imagine that's not a very big change, coding-wise...

  1. Woah, I never noticed it. You're way ahead of me! (Can you increase the size? :)

Also: Big Thanks for the best android twitter client I know, @mariotaku!

edent commented 7 years ago

The alt_text works great with Google Talkback. Thank you for this :-)

nevillepark commented 6 years ago

I know this is a very old issue, but didn't want to duplicate. I'd also like a way to view an image's alt text (on both Twitter and Mastodon). If an image doesn't have alt text I generally want to add a description of my own, but I can't do that if I can't tell if there's a description or not.

dannycolin commented 6 years ago

Same. I don't want to open an other issue. It would be nice to make the "add a description" a bit more visible. It took me awhile to find out that I need to press the edit button (it's so tiny :S).