Proxy settings label doesn't match content

[schemacs]

First of all, I'd like to express my sincere appreciation to you for developing such an amazing application.

Expected behavior

When Settings/Network//Advance/Proxy type is set to Reverse proxy, Settings/Network//Advance/Proxy host should be something like https://proxy.com/[SCHEME]/[AUTHORITY]/[PATH][?QUERY][#FRAGMENT] from this wiki page. This is different from what proxy host means when use HTTP proxy. What's more, proxy port(should the option be disabled ?) is ignored when using Reverse proxy.

Actual behavior

The label Proxy host is misleading or confusing when try to use reverse proxy, and the error message Invalid reverse proxy format is not so helpful.

Steps to reproduce

Settings/Network//Advance/Proxy: on Settings/Network//Advance/Proxy type: Reverse proxy Settings/Network//Advance/Proxy host: example.com Settings/Network//Advance/Proxy port: 443

When I login my twitter account with username/password, the toast says Invalid reverse proxy format

Extra info

Android version: (7.1.2)

Network type:

• [ ] Cellular
• [x ] Wi-Fi

App version: (3.6.21)

Build variant:

• [ ] Google
• [x ] F-Droid

Micro-blogging service:

• [x ] Twitter
• [ ] Fanfou
• [ ] GNU Social / StatusNet
• [ ] Mastodon

App settings:

• [ ] Custom API

• [ ] Custom consumer key/secrets

• [ ] Official keys

• [ ] Using Thumbor

• [x ] Connected through proxy

• [ ] Media preview enabled

  ​ The settings key proxy_host should not be changed, for user settings will break if we change it to proxy_host_or_format(or something else) . But I suggest two following changes which may clear the confusion:

  1. The error message should be changed here HttpClientFactory.kt#L263 , maybe we should put it into translations.

2. The translation key android:title="@string/proxy_host" at preferences_advanced_network.xml#L60 could be changed to proxy_host_or_format ?

I have sent you a draft PR, but we should discuss about how to resolve this issue before merge or close it.

[GEkuL]

Hi there, The issue is still opened, so I've decided to write here instead of making a new one.

Could you add a support for socks5 proxy?

I'm using proxy client with a port to connect the apps locally. Unfortunately, I wasn't able to proxy my Twitter traffic through the proxy. It seems like the proxy is not well configured (or I shouldn't use http option for socks like proxies even though they are located on a single device).

Btw, highly appreciate the proxy option! Most of apps doesn't have this essential (in case of internet censorship) feature. That's very nice!

Could you add socks support to proxy settings, so the app got even more sustainable to internet blockings?