search

TwidereProject / TwidereX-Android

Next generation of Twidere for Android
GNU General Public License v3.0
992 stars 53 forks source link

[Feature Request] Dynamic colours (Android 12) #343

Open Kernald opened 2 years ago

Kernald commented 2 years ago

Is your feature request related to a problem? Please describe. The current accent colour picker offers quite a lot of flexibility already, but it would be quite nice to re-use the OS' primary accent colour automatically when available (e.g. on Android 12+).

Describe the solution you'd like In the Appearance settings, a way to pick the OS' accent colour as highlight.

Describe alternatives you've considered Manually choosing a colour, which works fine but isn't exactly the same nor changes automatically when the OS' changes.

Additional context N/A

Tlaster commented 2 years ago

Our designer is trying out the new Material You design, including the dynamic color feature, but we don't have an ETA yet since the Material You design is still not well documented and the toolchain for implementing Material You design is still not ready for Jetpack Compose.

Qualentungo commented 2 years ago

What about using MonetCompat?

https://github.com/KieronQuinn/MonetCompat

Kernald commented 2 years ago

IMHO that's a nice technical demo, but not something that should really be used in apps - it's against user expectations on older Android versions to have the app using this kind of feature, and depending on how you use it, it can also end up with a different palette on Android 12 than the user's choice, which is not something desirable as an user either. I think the correct approach here is to wait for things to stabilise a bit in Compose around Material You (https://developer.android.com/jetpack/androidx/releases/compose-material3).