Integrate automated end to end tests with CI/CD

Twin-Cities-Mutual-Aid / twin-cities-aid-distribution-locations

A webapp to coordinate aid and care in the Twin Cities.

43 stars 32 forks source link

Integrate automated end to end tests with CI/CD #142

Closed crhistianramirez closed 4 years ago

crhistianramirez commented 4 years ago

This PR recently added end to end tests. Currently, these tests need to be run locally (manually). It would be better if they ran automatically.

Considerations:

These tests should run on every new pull request (and probably again anytime the PR changes)
Would be ideal if it worked with Netlify although it seems that might not be possible next best would be Gitlab CI or CircleCI

jdalt commented 4 years ago

I think TravisCI is free for open source projects. I've set it many times and I don't think it would be hard for this one. I think the default settings prevent merging if Travis fails.

My experience with Gitlab CI felt a bit more hand rolled. I haven't worked with CircleCI at all. Can anybody lay out the pros/cons of all 3 extant services?

benjifs commented 4 years ago

I just added some additional tests and submitted PR #143

I also ran TravisCI on my branch with all the tests and it worked pretty well so it should be fairly straightforward to setup.

https://travis-ci.org/github/benjifs/twin-cities-aid-distribution-locations/builds/695935214

jdalt commented 4 years ago

@benjifs Thank you. This warms my heart.