Closed crhistianramirez closed 4 years ago
Thank you for getting this based off of master. It's so much easier to take a peak at it. I don't have much time to add feedback, but overall this looks great!
Some thoughts:
Clear Search (viewing 80 of 120 locations)
. I'm not the UX person, so this is an idea and I think you should run it by the Dragon Riders and the #tc-ux-and-devs group.Clear Search
could use some love. I think some left margin is probably needed at the very list.
@crhistianramirez I am looking this over and have some comments. I would like to review it before it merges, I'll get back to you within a few hours. Thank you!
@estherrose046 sounds good! I won't be able to make updates until after 5pm anyway. Also there is a UX discussion happening in slack that might be interesting to you or others. It's in the #tc-ux-and-devs-group
@crhistianramirez @jdalt @estherrose046 thoughts on if it could look like this? or is this a ton of work (genuinely asking as I don't know the time or scoping to create this- v new here, much wow, many q's)
That looks good to me @drewsteff, good ux improvements.
Thanks for doing some detailed @estherrose046 non-fuzzy search it is
no problem @crhistianramirez - if anyone needs the styling if you want to use it here's the link to the page in figma for it
This is ready for review again.
The one thing I did slightly different is that I put the search results above the list (top right). My reasoning is that the information is useful independent of searching (ie when combined with filters)
Whoops, yeah the hidden fields were definitely meant to be hidden not sure how that happpened but its fixed now and merging master into my branch fixed the build issues.
user interaction pattern is mostly right but there are still some rough edges.
Could you elaborate on this? Maybe i'll post in the ux group a new link to the updated search
What
Adds basic search functionality.
Why
Helps users find locations they're interested more easily
Resolves part of https://github.com/Twin-Cities-Mutual-Aid/twin-cities-aid-distribution-locations/issues/127
Ensure the following interactions work as expected. Please test using a mobile form factor.
Check the app in the following web browsers: