search

Twin-Cities-Mutual-Aid / twin-cities-aid-distribution-locations

A webapp to coordinate aid and care in the Twin Cities.
43 stars 32 forks source link

Change "currently closed" text to read "not open now" #162

Closed mc-funk closed 4 years ago

mc-funk commented 4 years ago

We have had reports of confusion around the label for red pins being "currently closed" since people have inferred more permanence from it.

After a few discussions on the TCMAP side we agreed that "not open now" was adequately clarifying, and that the difference wasn't significant enough to need an immediate reevaluation of translations etc.

experimatt commented 4 years ago

@mc-funk this is a simple code change, but we'll need to get translations for "Not open now" in all of the languages in the spreadsheet 😬

mc-funk commented 4 years ago

@experimatt yeah, I meant to be clear that we think that it's worthwhile enough to improve the English issue for now while making sure we are keeping track of the possibility that we'd need to improve translations too. Since we don't have a process for updating translations and we're working on that.

Also, we're not sure the translations share the ambiguity of the English in the first place -- so yeah, it's a future concern for translators to evaluate for sure

experimatt commented 4 years ago

@mc-funk I just changed "currently closed" to "not open now" in the translation doc, and so that change is live in prod right now.

I'll also open a PR to update the hard-coded default text

experimatt commented 4 years ago

@mc-funk very small PR ready for your review :) https://github.com/Twin-Cities-Mutual-Aid/twin-cities-aid-distribution-locations/pull/163

experimatt commented 4 years ago

The initial fix of changing the wording of the English version is done! See https://github.com/Twin-Cities-Mutual-Aid/twin-cities-aid-distribution-locations/issues/164 for follow-up work to translate the wording change to other languages