Twin-Cities-Mutual-Aid / twin-cities-aid-distribution-locations

A webapp to coordinate aid and care in the Twin Cities.
43 stars 32 forks source link

issue #218: add russian translations #245

Open lizzyaustad opened 3 years ago

lizzyaustad commented 3 years ago

What

Add support for Russian translations

Why

Ticket #218

Ensure the following interactions work as expected. Please test using a mobile form factor.

Check the app in the following web browsers:

lizzyaustad commented 3 years ago

@amaxama thanks! I removed the image file and the image references in the new language instructions. Let me know if there were any other issues with the PR I missed

lizzyaustad commented 3 years ago

@amaxama it looks like my previous comment was removed, but I had mentioned that the moment.js translation did exist and was ru not rus. I asked if you still wanted the 3-letter country code instead of the 2-letter version that moment.js supports and if not, whether the instructions about using the moment code should be removed. I didn't hear back, so I guessed that you still wanted to use the 3 letter country code and that the instructions to use the moment code were no longer relevant. Can you clarify which code you would like me to use?

amaxama commented 3 years ago

@lizzyaustad I don't think I ever saw your previous comments. Oh sorry, I was just saying to use 3 letters when naming the json file since that's what was in the language_translation file, not necessarily for the moment locale. It doesn't really matter that much about the file name, I was just thinking about consistency. Sorry if I was unclear before! But I think the moment stuff is still relevant.