Closed kanadgupta closed 3 years ago
@amaxama any idea what Travis CI does? Is it just for running tests? Any way we could also have it do an ESLint check as well? I couldn't find anything about it in the config 🤔
I could also set up a GitHub CI (which should be free) to run the lint check?
@amaxama any idea what Travis CI does? Is it just for running tests? Any way we could also have it do an ESLint check as well? I couldn't find anything about it in the config 🤔
Yeah, it's for running tests...I would thing it would be pretty easy to add a pipeline step to run and eslint check, but haven't looked into it! 🤔 I think you could just add a script block in the travis.yml with the command
I could also set up a GitHub CI (which should be free) to run the lint check?
Seems like we should use one or the other? I'm not opposed to switching but probably don't need two CI pipelines? What do you think?
What
Adds minimal ESLint config and fixes some glaring issues in our core JS files. Also does a minor bump of our Node version to ensure we're on the most secure version.
Why
This is very light touch (i.e. no style changes, etc.) but this will help eliminate bugs and dead code.
Ensure the following interactions work as expected. Please test using a mobile form factor.
Check the app in the following web browsers: