Closed TwinFan closed 3 years ago
TwinFan
commented
3 years ago After a number of quite significant changes to position handling throughout LiveTraffic (in the course of fixing #207 and #210) I am not currently able to reproduce this auto-land problem any longer. Asked one user to provide me with an airport to try.
TwinFan
commented
3 years ago ...and just when I wanted to give up the last still flying plane did not even reach the touch-down but disappeared shortly before.
Looking at the log what happened was:
Added final), together with the actual touch-down node (Added touch-down)0:17:44.839 LiveTraffic DEBUG LTFlightData.cpp:985/CalcNextPos: A479D8 N388JP: Added final 40.2982 N / 104.2363 W
0:17:44.839 LiveTraffic DEBUG LTFlightData.cpp:990/CalcNextPos: A479D8 N388JP: Added touch-down 40.2997 N / 104.2308 W
0:17:44.839 LiveTraffic DEBUG LTFlightData.cpp:1325/CalcNextPos: DEBUG POS DATA: a/c A479D8 N388JP SimTime: 1612304739.1 - 2021-02-02 22:25:39
a/c ICAO A479D8 (DA40 N388JP)
<undefined> <- turn
1612304739.0: (40.29781, -104.23980) 4566.3ft GND_OFF Final {h 75 , p 2, r 0} Y: 4476.0ft 80kn -352ft/m Phase: 61 Final
posList:
1612304720.0: (40.29595, -104.24872) 4678.2ft GND_OFF Final {h 75 , p 2, r 0} <h 75, 824m @ 80kt, -352ft/m>
1612304740.0: (40.29791, -104.23935) 4560.7ft GND_OFF Approach {h 75 , p 2, r 0} <h 82, 258m @ 112kt, -352ft/m>
posDeque:
1612304744.5: (40.29823, -104.23634) 4534.5ft GND_OFF RWY Final {h 71*, p 0, r 0} <h 71, 500m @ 70kt, -352ft/m>
1612304758.3: (40.29970, -104.23076) 4453.0ft GND_ON RWY Touch Down {h 71*, p 5, r 0}
posToAdd:
<empty>
0:17:45.310 LiveTraffic DEBUG LTFlightData.cpp:2025/TryFetchNewPos: DEBUG POS DATA: a/c A479D8 N388JP SimTime: 1612304739.6 - 2021-02-02 22:25:39
a/c ICAO A479D8 (DA40 N388JP)
<undefined> <- turn
1612304739.5: (40.29785, -104.23960) 4563.9ft GND_OFF Final {h 75 , p 2, r 0} Y: 4475.8ft 80kn -352ft/m Phase: 61 Final
posList:
1612304720.0: (40.29595, -104.24872) 4678.2ft GND_OFF Final {h 75 , p 2, r 0} <h 75, 824m @ 80kt, -352ft/m>
1612304740.0: (40.29791, -104.23935) 4560.7ft GND_OFF Approach {h 75 , p 2, r 0} <h 82, 258m @ 112kt, -352ft/m>
1612304744.5: (40.29823, -104.23634) 4534.5ft GND_OFF RWY Final {h 71*, p 0, r 0} <h 71, 500m @ 70kt, -352ft/m>
posDeque:
1612304758.3: (40.29970, -104.23076) 4453.0ft GND_ON RWY Touch Down {h 71*, p 5, r 0}
posToAdd:
<empty>
0:17:45.819 LiveTraffic DEBUG LTAircraft.cpp:1620/CalcPPos: DEBUG A/C SWITCH POS: a/c ICAO A479D8 (DA40 N388JP)
<undefined> <- turn
1612304740.0: (40.29790, -104.23936) 4560.9ft GND_OFF Final {h 75 , p 2, r 0} Y: 4475.5ft 80kn -352ft/m Phase: 61 Final
posList:
1612304740.0: (40.29790, -104.23936) 4560.9ft GND_OFF Final {h 75 , p 2, r 0} <h 82, 259m @ 112kt, -352ft/m>
1612304744.5: (40.29823, -104.23634) 4534.5ft GND_OFF RWY Final {h 71*, p -0, r 0} <h 71, 500m @ 70kt, -352ft/m>
0:17:45.819 LiveTraffic DEBUG LTAircraft.cpp:455/StartSpeedControl: CONSTANT SPEED due impossible speeds (start=41.2,avg=57.8=259.4m/4.5s,target=50.3) for a/c ICAO A479D8 (DA40 N388JP)
<undefined> <- turn
1612304740.0: (40.29790, -104.23936) 4560.9ft GND_OFF Final {h 75 , p 2, r 0} Y: 4475.5ft 80kn -352ft/m Phase: 61 Final
posList:
1612304740.0: (40.29790, -104.23936) 4560.9ft GND_OFF Final {h 75 , p 2, r 0} <h 82, 259m @ 112kt, -352ft/m>
1612304744.5: (40.29823, -104.23634) 4534.5ft GND_OFF RWY Final {h 71*, p -0, r 0} <h 71, 500m @ 70kt, -352ft/m>
0:17:45.819 LiveTraffic DEBUG LTAircraft.cpp:2173/CalcFlightModel: DEBUG A/C FLIGHT PHASE CHANGED from 61 Final to 50 Descend
0:17:45.819 LiveTraffic INFO LTAircraft.cpp:1280/~LTAircraft: Removed aircraft ICAO A479D8 (DA40 N388JP)
0:17:45.819 LT/XPMP2 DEBUG Aircraft.cpp:622/DestroyInstances: Aircraft 0xA479D8: Instance destroyed
Describe the bug Auto-landing aircraft (those with no data leading down to ground) do approach a runway correctly, flare, but then disappear immediately upon touch-down.
Observed while analyzing #207. Recently, user complains about disappearing aircraft had increased...but i didn't get that they talk about disappear upon touch-down as opposed to disappear after roll-out.
To Reproduce Enforce auto-land by switching off the feeding channels while some planes are already in the air approaching runways.
Expected behavior After touch-down the plane shall roll out on the runway, decelarate to a full stop, and only then disappear.
Technical Info:
Log.txt Log - Copy (2).txt
This one has two examples with full position logging: "A0B316 (T6 N144RU)" and "A24757 (B737 WN3031)". The part of the log around touch down looks similar. Here for A0B316 (T6 N144RU) - ordered in a way that makes sense, original log file position was a bit scrambled as entries are written from different threads in parallel:
Rough guess: It looks like Final and Touch-Down positions are added again, although the position queue already contains both. That leads to a position validation error resulting in immediate aircraft removal.