search

TwinFan / LiveTraffic

LiveTraffic is an X-Plane multiplayer plugin, which fills your sky with live air traffic based on public flight tracking data.
https://twinfan.gitbook.io/livetraffic/
Other
100 stars 25 forks source link

OGN: APRS Message Format mismatch #258

Closed TwinFan closed 9 months ago

TwinFan commented 9 months ago

Describe the bug

Found again lots of warnings in the log about mismatches while parsing APRS messages in the OGN data stream. Will need to review the regex once again.

To Reproduce

Activate OGN channel. How and where exactly such message are sent is difficult to predict. A collection down below.

Expected behavior

APRS messages shall be properly processed. Also, we probably need to review the logging behaviour here because if it happens it produces a lot of log output.

Technical Info

Log.txt

0:03:41.016 LiveTraffic WARN  LTOpenGlider.cpp:550/APRSProcessLine: An APRS message could be tracking data, but didn't match: FNT08A689>OGNFNT,qAS,WHill:/193304h5115.69N\00005.63Wn !W90! id3F08A689 FNT71 30.0dB -1.9kHz
0:03:56.076 LiveTraffic WARN  LTOpenGlider.cpp:550/APRSProcessLine: An APRS message could be tracking data, but didn't match: FNT08A689>OGNFNT,qAS,WHill:/193319h5115.69N\00005.62Wn !W88! id3F08A689 FNT71 26.5dB -1.8kHz 3e
0:04:01.192 LiveTraffic WARN  LTOpenGlider.cpp:550/APRSProcessLine: An APRS message could be tracking data, but didn't match: FNT08A689>OGNFNT,qAS,WHill:/193324h5115.69N\00005.62Wn !W98! id3F08A689 FNT71 26.0dB -1.8kHz 12e
TwinFan commented 9 months ago

The above messages are in fact incomplete, e.g. don't they contain an altitude value, and that means we couldn't process them anyway. So it is actually totally OK to discard them.

However, we need to change the logging as currently in such a case each and every received message is copied into Log.txt.