search

TwinFan / XPMP2

Multiplayer library for X-Plane 11/12 with instancing, TCAS override, and sound
https://twinfan.github.io/XPMP2/
Other
24 stars 16 forks source link

Mac/OpenGL: X-Plane crashes after XPLMSetAircraftModel #3

Closed TwinFan closed 4 years ago

TwinFan commented 4 years ago

Problem This has been reported to Laminar and accepted as XPD-10727: On Mac OS, in XP 11.50, at least Betas 3+4, and in OpenGL-mode only, X-Plane crashes after a plugin set a user's aircraft model via a call to XPLMSetAircraftModel.

Current Situation in XPMP2 XPMP2 currently includes a safeguard against this crash in form of the config item XPMP_CFG_ITM_SKIP_NOPLANE = "skip_assign_noplane". This is on most cases by default false, only in case of Mac + OpenGL this defaults to true. As a standard config item it can be overwritten by the calling application in the configuration callback.

This config item controls globs.bSkipAssignNoPlane, which in turn in function AIInitPlanes controls if the call to XPLMSetAircraftModel is actually performed.

If the call is not performed, then X-Plane's AI/multiplayer planes will be shown as configured in X-Plane's aircraft settings. If the user configured standard planes there, then they will show in the 3D world overlaid on the XPMP2 planes. Same goes for the map: Two icons stacked over each other.

Workaround: On Mac (and others if he likes) the user could copy NoPlane.acf into the Aircraft folder and then directly assign as an AI plane type. Then again would X-Plane not draw anything into "our" 3D world.

Next Steps This issue is to track XPD-10727. If it got fixed all the code related to XPMP_CFG_ITM_SKIP_NOPLANE/bSkipAssignNoPlane can probably be removed again.

TwinFan commented 4 years ago

XPD-10272 has been fixed with XP11.50 Beta 5. It is on the release notes. So I removed the workaround code and successfully tested the XPMP2-Sample with the Beta 5...and then Beta 5 got recalled.

So the workaround code is already removed. And LiveTraffic 2.0 is actually published without.

I keep this issue open until Beta 5 comes back and we can finally close the problem officially for good.

TwinFan commented 4 years ago

Now...beta 6 is out and XPMP2 still works.