Inverse Vulkan Z-Axis - Prevent Mirrored Aircraft Labels

TwinFan / XPMP2

Multiplayer library for X-Plane 11/12 with instancing, TCAS override, and sound

https://twinfan.github.io/XPMP2/

Other

24 stars 16 forks source link

Inverse Vulkan Z-Axis - Prevent Mirrored Aircraft Labels #6

Closed justinshannon closed 4 years ago

justinshannon commented 4 years ago

Vulkan's z-axis is an inverse of OpenGL's z-axis [0,1] as opposed to [-1,1].

This PR addresses an issue with aircraft labels being mirrored behind the camera view (i.e. by rotating the camera 180°, the labels are visible still).

I do not have access to X-Plane on MacOS, so I'm not sure if this change would adversely affect label rendering with the Metal driver.

TwinFan commented 4 years ago

Thanks, that code is indeed not yet tested on Windows and not productive (in LiveTraffic) either, so you might have a point here. I had implemented and tested it so far only on MacOS (incl. Metal), so it seems Metal likes the -1...1 range. I will merge and then take care of the MacOS handling.