Closed astroash closed 5 years ago
Merging #351 into master will increase coverage by
0.04%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 94.27% 94.31% +0.04%
==========================================
Files 104 104
Lines 1955 1934 -21
Branches 275 271 -4
==========================================
- Hits 1843 1824 -19
+ Misses 82 80 -2
Partials 30 30
Impacted Files | Coverage Δ | |
---|---|---|
src/api/v1/types.ts | 100% <ø> (ø) |
:arrow_up: |
src/auth/permissions/index.ts | 100% <ø> (ø) |
:arrow_up: |
src/auth/strategies/standard/validate.ts | 100% <100%> (ø) |
:arrow_up: |
src/auth/strategies/standard/session.ts | 68.75% <100%> (-5.17%) |
:arrow_down: |
src/api/v1/users/login.ts | 96.42% <100%> (+1.3%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9ad1b46...bb1eacb. Read the comment docs.
Manual testing:
GET http://localhost:4000/v1/users/volunteers/me/volunteer-logs/summary?since=2019-02-26T23:00:00.000Z&until=2019-02-27T22:59:59.999Z
returns 403
master
too@eliascodes let me know if you would like https://github.com/TwinePlatform/twine-api/issues/353 fixed in this deployment
Changes:
Manual Testing
CB_ADMIN
Partnered PR: https://github.com/TwinePlatform/twine-visitor/pull/698