TwinePlatform / twine-api

⚠️ DEPRECATED - See https://github.com/TwinePlatform/twine-monolith
GNU Affero General Public License v3.0
3 stars 0 forks source link

πŸš€ DEPLOYMENT 06-03-19 #367

Closed astroash closed 5 years ago

astroash commented 5 years ago

Changes:

Partnered PR: https://github.com/TwinePlatform/twine-visitor/pull/703

astroash commented 5 years ago

@eliascodes do you mind looking at the conflict. I think it's from one of your PRs

astroash commented 5 years ago

366 should not be in this PR. This is showing from rebasing deployment last week. Not sure how this is going to effect git history.

eliasmalik commented 5 years ago

366 should be in this PR. Do you mean #336?

eliasmalik commented 5 years ago

do you mind looking at the conflict. I think it's from one of your PRs

It's actually a result of your hotfixes #359 and #360. I don't know which user ID is the right one.

codecov-io commented 5 years ago

Codecov Report

Merging #367 into master will decrease coverage by 0.49%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #367     +/-   ##
=========================================
- Coverage   94.31%   93.81%   -0.5%     
=========================================
  Files         104      104             
  Lines        1934     1779    -155     
  Branches      271      151    -120     
=========================================
- Hits         1824     1669    -155     
- Misses         80       83      +3     
+ Partials       30       27      -3
Impacted Files Coverage Ξ”
src/models/types.ts 100% <ΓΈ> (ΓΈ) :arrow_up:
src/api/v1/utils.ts 89.47% <ΓΈ> (-1.84%) :arrow_down:
src/api/v1/users/schema.ts 100% <ΓΈ> (ΓΈ) :arrow_up:
src/api/v1/schema/request.ts 100% <ΓΈ> (ΓΈ) :arrow_up:
src/models/volunteer.ts 92.5% <ΓΈ> (-0.69%) :arrow_down:
src/api/v1/users/volunteers/volunteer_logs.ts 100% <100%> (ΓΈ) :arrow_up:
src/api/v1/community_businesses/volunteer_logs.ts 88.75% <100%> (-1.78%) :arrow_down:
src/models/community_business.ts 98.09% <100%> (-0.07%) :arrow_down:
src/api/v1/hooks/on_pre_response.ts 100% <100%> (ΓΈ) :arrow_up:
src/models/user.ts 95.77% <100%> (+0.12%) :arrow_up:
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 3f44dcc...d3a8793. Read the comment docs.

astroash commented 5 years ago

@eliascodes I've partnered this with TwinePlatform/twine-visitor#703 as i do not think there are many client facing changes.

Do you think any other manual testing needs to be done?

eliasmalik commented 5 years ago

Entering data with trailing spaces and checking it's trimmed off.