Closed astroash closed 5 years ago
Merging #386 into staging will decrease coverage by
<.01%
. The diff coverage is98.73%
.
@@ Coverage Diff @@
## staging #386 +/- ##
===========================================
- Coverage 93.54% 93.54% -0.01%
===========================================
Files 112 112
Lines 1921 1920 -1
Branches 148 148
===========================================
- Hits 1797 1796 -1
Misses 96 96
Partials 28 28
Impacted Files | Coverage Δ | |
---|---|---|
src/models/permission.ts | 100% <ø> (ø) |
|
src/auth/types.ts | 100% <ø> (ø) |
:arrow_up: |
src/api/v1/community_businesses/visit_logs.ts | 88.46% <100%> (ø) |
:arrow_up: |
src/api/v1/community_businesses/volunteer_logs.ts | 93.42% <100%> (ø) |
:arrow_up: |
src/api/v1/community_businesses/register.ts | 95% <100%> (+0.26%) |
:arrow_up: |
src/models/types.ts | 100% <100%> (ø) |
:arrow_up: |
src/models/volunteer_log.ts | 94.44% <100%> (ø) |
:arrow_up: |
src/models/role.ts | 93.75% <100%> (ø) |
|
src/api/v1/users/password.ts | 96.15% <100%> (+0.15%) |
:arrow_up: |
src/api/v1/users/register/volunteers.ts | 92.59% <100%> (+0.28%) |
:arrow_up: |
... and 14 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8d849fd...a89dd11. Read the comment docs.
closing as this has been recreated in mono https://github.com/TwinePlatform/twine-main/pull/11
Refactor Changes:
Notes: I've not moved
EmailService
as its interface that needs initialising. I suggest that this is refactored into a similar format as model methods that use knex, and email configuration is passed toEmailService