search

TwinePlatform / twine-monolith

⬛️ Monorepo for the Twine platform
https://twine-together.com
GNU Affero General Public License v3.0
5 stars 3 forks source link

🐶 Husky #319

Open astroash opened 4 years ago

astroash commented 4 years ago

As our test currently take ~20mins to run we loose a fair amount of time waiting for them to pass/reassigning each other on PRs.

I think it would be useful to test out installing husky in our root directory to ensure all tests pass before we commit

https://github.com/typicode/husky

Thoughts?

eliasmalik commented 4 years ago

Pre-push hook is fine by me, I think a pre-commit hook would get annoying (and disabled) extremely quickly.

I think the fundamental issue though is, maybe we should look at speeding up the build. Some of the test suites take ~10s which feels ridiculous. There's also maybe other stuff we can do to speed up the provisioning of the environment on travis.

astroash commented 4 years ago

Okay, let's go for a pre-push hook.

You're right, this does not solve the issue of long build/test times, but does give some structure to alleviate current workflow time sinks.

From my POV, I feel like our tests will always be fairly long by virtue of having a monorepo. Even if we manage to drop the time to ~15mins, I would still be waiting around and playing assign hockey 🏒 when tests fail. Not to say that we shouldn't look at making them faster, just that I don't see it as a priority atm.