Delay Option for Dialogue transtions

[JeffreyGaydos]

• Instead of having the player advance the dialogue directly by responding, allow the option to automatically advance the dialogue after a delay
  • This seems to be a common way to implement dialogue in MC Maps if you do not intend to have much player interaction
  • This could possibly be exported to a new tool, but it also seems like this should go into this tool in case you want delays sometimes, and player interaction also
• Requires creating a standalone datapack export to allow for additional tick/load functionality

[JeffreyGaydos]

Front end complete.

This feature feels like "convention over configuration". If the user enters an integer (and no other extraneous characters) in the input field, the input will be interpreted as a delay input.

Delay inputs can only be put on child nodes (also child nodes can be converted to delay nodes and back)

✅ Tellraw to HTML parser is not really aware of this fact, so sometimes it gives errors that may confuse users if they do not know that you can't convert NPC nodes to delay nodes

Should you be able to paste-as-link delay nodes? It would be cool because then you could do weird things with small delays.

• Yeah why not? As long as it's not hard in the backend... You can make heartbeats with this essentially which is cool I guess

Should NPC nodes also be delayable? (i.e. allows player nodes to be displayed 1-by-1 with delay)

• No, we can add more conventions to this sort of thing; see below comments about parsing rules

Enforce that delays are positive (this means not 0 either)

[JeffreyGaydos]

Couple issues:

• ✅ After parse error related to NPC nodes being unable to be converted to delay nodes, adding another delay node forces the NPC node through to a delay node somehow
• ⚠️ After parsing issues, sometimes the ROOT gets replaced; this may or may not be related to the new delay node functionality
  • This has not been observed recently

[JeffreyGaydos]

Some weird rules that we will have to explain (and implement in the MC backend)

• The system "parses" player nodes from top to bottom (it parses all nodes this way BTW)
• When the system encounters a delay node, it delays regardless of how many children the delay node has
  • ✅ If the delay node is childless: after delaying, continue to parse any sibling player nodes
  • intended to add a delay in-between player response during dialogue (for dramatic effect or something idk)
  • ✅ 🐞 Fix warning for childless player nodes when those nodes are delay nodes (not particularly warning-worthy)
  • ✅ If the delay node has children: after delaying, display the first active child NPC node (existing functionality)
  • intended to allow for the "classic" MC style of dialogue, where the play has no options, and it just gives them a quest

This is the simplest way of allowing for these scenarios without degrading the flexibility of the system, but it does allow the user to do some pretty stupid things like displaying some dialogue immediately, then waiting and before the player can answer, the NPC says something else; which, come to think of it, is actually pretty cool if you had some sort of time-sensitive issue that you needed to respond to in a dialogue. - Update on this weird scenario: currently, it parses and displays all children text, regardless of order in the list of child responses, then after a delay displays the child of the delay node, as expected. You may want to leave it this way since it does not make sense to hide the option that is after the delay node until the delay has finished and we've moved on to the next NPC dialogue, because then the option that was now revealed with by locked out by our locking system...

[JeffreyGaydos]

✅ Bug: conversion from delay to player node (and back) does not update image until another refresh happens

[JeffreyGaydos]

✅ Bug: no parsing logic for delay nodes Try to just extract the useful/shared parts of TellrawToHTML to re-implement the ImportTellrawCode function and fill in the rest maintaining backwards compatibility

[JeffreyGaydos]

✅ 🐞 Incorrect detection of delay nodes present in dialogue model. Always creates a tick function.

• Note: the detection function was fixed AFAIK, but for something that doesn't need a tick function, (like during a conditional) a non-existent tick function is being added to the tick.json file. See condtest2
  • This is extra nasty since it stops ALL ticks defined in all datapacks from running
  • This may or may not only appear for when there is a "first level transition" needed (see the new code you just added in the CreateStartFile function
• The Zipping function was the culprit, only had checks for standalone, not for the hasDelay parameter (which was made after the tick creation mechanics)

[JeffreyGaydos]

Last thing to do is some tests I guess:

• multiple sections of player delays
• multiple values of player delays
• player delay as the final node in layer
  • Any actions on this node should trigger after the delay
• conditions on player delays
• actions on player delays
• conditions and actions on player delays
• linked player delays (unimplemented)
• linked player delays with actions and conditions
• multiple sections of NPC delays
• multiple values of NPC delays
• player nodes with NPC delays
• conditions with NPC delays
• actions with NPC delays
• conditions and actions with NPC delays
• linked NPC delays (unimplemented)
• Everything:
  • 2+ layers with both player and NPC delay nodes
  • conditions on each kind of delay
  • actions on each kind of delay
  • links to exemplary delay nodes in separate layer

[JeffreyGaydos]

Implement linked/copied/cut delay nodes

• ✅ 🐞 Note: there is an outstanding bug where the linked nodes full data model is not being copied after all user actions
  • afaik this is all good now. Don't quote me on that

[JeffreyGaydos]

✅ 🐞 Locking mechanics fail when there are childless delay nodes

• Has to do with the fact that once you enter a childless delay node, the next tellraw is not triggered by "you" (or the @s that called init), but by the system itself (via the various constantly ticking functions)
• We will be forced to use the marker once again (which, we should add the ability to name it btw)
  • ~The name mechanics will require the use of a marker for every kind of thing~ Actually I don't know if there is a way to make it not display as a "Server Message", so the only option the user will have is the text itself
  • This became more prevalent when they added the indicator thing on the side of the chat
  • Except that the name of the entity doesn't really show up in those side chat things

[JeffreyGaydos]

⚠️ This is currently in a pretty inconsistent state. Recommend re-working simpler cases before tackling linked childless delay nodes