Twingate / terraform-provider-twingate

Mozilla Public License 2.0
42 stars 11 forks source link

Add a "DENY_ALL" policy option in the twingate_resource.protocols resource definition #70

Closed alexmensch closed 2 years ago

alexmensch commented 2 years ago

The current allowed states for protocols in our provider are ALLOW_ALL and RESTRICTED. This is based on the ProtocolPolicy object in our public GraphQL API. ALLOW_ALL allows all ports for a given protocol, and RESTRICTED allows specifying an allowed range. If this range is null, no ports are allowed for that protocol.

To enhance the clarity/usability of our Terraform provider, we will add a DENY_ALL state for the protocol that acts as a shortcut for the RESTRICTED state with an empty port range.

alexmensch commented 2 years ago

Hey @vmanilo, I just updated the description to make it clearer. I’m also going to create a separate issue that’s related to this, which is that when you specify an empty port range, our provider crashes.