Update to OIDN 1.3 (API changes)

Twinklebear / oidn-rs

Rust bindings to Intel's OpenImageDenoise Library

MIT License

24 stars 12 forks source link

Update to OIDN 1.3 (API changes) #16

Closed virtualritz closed 3 years ago

virtualritz commented 3 years ago

Specifically (from the changelog)

Added inputScale filter parameter which generalizes the existing (and thus now deprecated) hdrScale parameter for non-HDR images

Twinklebear commented 3 years ago

Hey Moritz, thanks for the heads up, I didn't know about this API change. I'm preparing for my phd defense next week so I won't get to this til then but it should be quick to change, but just to note that I'm not ignoring the issue :D

virtualritz commented 3 years ago

Best of luck with your defense. I'm not using the API addition/change. I just made the ticket so it doesn't fall through the cracks.

Twinklebear commented 3 years ago

This is resolved in e2a6f1c which internally moves to use the inputScale parameter and adds RayTracing::input_scale to the API. RayTracing::hdr_scale is still provided but now has a deprecation warning to avoid making this an API breaking release.