Twinklebear / tobj

Tiny OBJ Loader in Rust
MIT License
233 stars 47 forks source link

Add support for merging disconnected vertices w. matching positions on import #41

Closed virtualritz closed 3 years ago

virtualritz commented 3 years ago

I think I have this working for positions & indices. Possibly should also do the same for normals/texcoords and the resp. index buffers.

But would be good to get feedback before I create a PR. It's in my reordering branch which has two new feature flags, reordering and merging to ensure dependencies & compile time stay the same for users of the crate who don't need these features.

virtualritz commented 3 years ago

I added support for merging of normal & texcoord indices too now. To avoid code duplication, the code uses const generics. This means the reordering branch will only build with a beta toolchain atm.

This could be changed by copypastaing the code for the textcoord case ofc.

Twinklebear commented 3 years ago

This is part of the PR and now in 3.0.0 correct? So we can close this