search

Twinklebear / tobj

Tiny OBJ Loader in Rust
MIT License
235 stars 47 forks source link

Multi-index, merging, docs, etc. #42

Closed virtualritz closed 3 years ago

Twinklebear commented 3 years ago

It looks like for CI we should also take out the #[feature(test)] use, is that still needed for testing? Or that's been stabilized now?

Edit: In doing a check locally, I think that isn't needed anymore

virtualritz commented 3 years ago

It looks like for CI we should also take out the #[feature(test)] use, is that still needed for testing?

I cleaned that up.

Twinklebear commented 3 years ago

The readme change we can probably drop from this PR. For the PR, did you want to add tests as part of it? Or leave that for later? If you wanted to wait on the tests I think this is ready to merge

virtualritz commented 3 years ago

Yes, I only added that section since I got some messages asking me about it because of the Rust game newsletter which mentions tobj under my opensubdiv-petite contrib.

I do not have time to add tests atm. I.e. I'd release to get it out in the wild – fastest way to find issues if I overlooked something.

That said: I am using all of the new features in my code; it is just a bit of work to isolate that into small tests. I'll get to it eventually.

Twinklebear commented 3 years ago

Sounds good, yeah to me the changes look good as well, the tests are just nice to have for regression testing in the future. I'll merge this tonight and cut a release