Twinside / Juicy.Pixels

Haskell library to load & save pictures
BSD 3-Clause "New" or "Revised" License
238 stars 57 forks source link

Addition of `paletteSize`, while removing private field of `Palette'` #184

Open lehins opened 4 years ago

lehins commented 4 years ago

From what I gather _paletteSize is an unnecessary field in Palette', since it can be deduced from the size of _paletteData and the type of pixel, which is exactly the way that the newly added paletteSize is implemented. Couple benefits that come from this change:

Twinside commented 4 years ago

At this point, while this is a worthwhile enhancement, I wouldn't break compatibility for such "low" issue, has to keep it in mind in case of bigger breaking change

lehins commented 4 years ago

@Twinside I agree, that bundling this together with a bigger breaking change is a good idea.