search

Twipped / Kalendae

A javascript date picker that just works.
MIT License
1.99k stars 285 forks source link

unable to manually type in a date #103

Closed morficus closed 8 years ago

morficus commented 11 years ago

At some point... the decision was made to call setSelected() every time the user types into the bound input box (see here: https://github.com/ChiperSoft/Kalendae/blob/master/build/kalendae.js#L821)

The issue with this... is that users are now unable to manually type in a date. My suggestion is to do this on blur, not key-up.

If folks agree with this, I can issue a quick pull-request to address this.

klewin commented 11 years ago

+1

However when the event is changed to blur, the user is still not able to clear the value.

Deleting the previously selected date and exiting the field, the original value is replaced with "undefined". Clicking back in the field and the value then changes to "01/01/0000".

Otherwise, fantastic date control!

Twipped commented 11 years ago

Can you please see if this is still happening on the dev branch? I think we fixed this already.

klewin commented 11 years ago

Seems to be working fine. Thanks.

tagliala commented 11 years ago

@ChiperSoft I'm still waiting feedbacks for the other issue before merging in develop and release a new version