search

Twipped / Kalendae

A javascript date picker that just works.
MIT License
1.99k stars 285 forks source link

Moment deprecation warning #159

Closed reintroducing closed 8 years ago

reintroducing commented 8 years ago

I'm using my own version of moment and sometimes I'm seeing this warning come up when going through months in Kalendae.

Deprecation warning: moment().subtract(period, number) is deprecated. Please use moment().subtract(number, period).

I can't quite place how to reproduce this exactly but I'm sure its coming from Kalendae as it only happens when using a calendar. Just wanted to give you a heads up so you can maybe put a version check in for that depending on when that changed and what your expectation of the API from moment is.

Twipped commented 8 years ago

I've just pushed out version 0.5.5, which includes this fix.

reintroducing commented 8 years ago

awesome, appreciate the quick reply!