Twipped / Kalendae

A javascript date picker that just works.
MIT License
1.99k stars 285 forks source link

Several additions: endDate view option, 'draw-end' event, removeAllSelected() method, caption changes, & 'k-blackout' class #161

Closed coreyzev closed 8 years ago

coreyzev commented 8 years ago

First off, this has as lot of changes (though mostly very simple) in one request. I did not test extensively. But I have been working in Chrome & IE9. So far, so good.

Feel free to take bits and pieces of this.

I made sure to break it up into commits for each feature. So you can see each one on its own. (Aside from the last commit, which was a bit of an afterthought).

In more detail:

thanks for making such a great, agnostic, datepicker! I'm really enjoying using it. And modifying it.

coreyzev commented 8 years ago

I am working with Kalendae again for the first time since last year, and I will need some of these changes again.

Obviously I will need to fix the conflicts, but is there anything else in particular that kept you from either refusing or accepting this pull request?

Such as making a pull request for each new feature?

Twipped commented 8 years ago

I don't remember seeing this PR before, so I think I just somehow overlooked it. The changes look reasonable, if you can address the conflicts then I'll merge it.

Twipped commented 8 years ago

Since there's a lot of new features in this PR, could you also update the changelog with everything it adds, under the In Development heading.

coreyzev commented 8 years ago

Conflicts fixed, need to update the changelog

coreyzev commented 8 years ago

Okay. That was so much rebasing... but it's done. I apologize the builds are in there, but I think it might be too late to change?

Thanks!

Twipped commented 8 years ago

Rocking. Will try to wrap up a release this weekend.

coreyzev commented 8 years ago

I just realized I forgot to add the changelog the new class k-blackout.