search

Twipped / Kalendae

A javascript date picker that just works.
MIT License
1.99k stars 285 forks source link

move dependencies to npm #216

Closed DanielRuf closed 6 years ago

DanielRuf commented 6 years ago

bower is dead and all dependencies should be managed by npm

Twipped commented 6 years ago

There are no dependencies. The only thing Kalendae relies upon is Moment, and it's bundled into the library. The bower dep is just there for people who want to use the unbundled version so they can have Moment globally. You'll notice that Moment is not included in the npm dependencies.

DanielRuf commented 6 years ago

Then it's unclear to me why it is a dependency in bower.json but not package.json. Is it required by them eg for imports/requires?

Twipped commented 6 years ago

I actually didn't write the Bower.json, it was added via a pull request, so I don't know why it's there. I've historically had a lot of problems with the bower registry because of third parties pushing my libraries up there and then letting them rot. I don't really interact with it at all, I just push tags for the new releases and supposedly that makes it work.

DanielRuf commented 6 years ago

I guessthe line can be deleted as the dependencies are shipped with it https://github.com/Twipped/Kalendae/tree/master/src