'Today' does not respect current timezone

[danhodos]

Hello! I noticed this problem with Kalendae's notion of what today is, and wanted to bring it up here.

Steps to reproduce:

• Set your system time to 2PM, Chicago time (I am doing this through System Preferences on Mac OS X)
• Visit http://chipersoft.com/Kalendae/
• Scroll down to the bottom of the page
• Note that the day indicated as today (underlined, with the CSS class of k-today) is today (in my case: Wed, May 29, 2013).
• Set your system time to 9PM, Chicago time (I am doing this through System Preferences on Mac OS X)
• Reload http://chipersoft.com/Kalendae/
• Scroll down to the bottom of the page

Expected behavior: the day indicated as today (underlined, with the CSS class of k-today) is today (in my case: Wed, May 29, 2013).

Actual behavior: the day indicated as today (underlined, with the CSS class of k-today) is tomorrow (in my case: Thu, May 30, 2013).

[roryf]

The build on http://chipersoft.com/Kalendae/ is v0.2 which is out of date, should re-test this with latest from repo.

[magnars]

This is a problem for us too. In 0.4.1.

[yogendra689]

Date should change according to System timezone. Jquery Datepicker changes according to System timezone. This is not happening in Kalendae js.

[tagliala]

The date is taken from system timezone but there is a strange calculation of "dayyear" that is rounded up to the next day under certain circumstances.

I suppose the best way to do it is always convert time to UTC at midnight. I was making some tests but I wasn't able to find a fast fix

[yogendra689]

I fixed it using a variable .. check_today = moment(new Date()).format("YYYY-MM-DD"); and using condition if (day.format("YYYY-MM-DD") === check_today) klass.push(classes.dayToday);

This gives me local date according to system timezone. This solved my problem. Now it is showing correct local date as underlined.

[yogendra689]

I think problem is with dayyear() function, it extracts current date using epoch. I think in this case we get current UTC date instead of local date

[tagliala]

@yogendra689 you should be right. I'm going to take a look right now

[Twipped]

@tagliala If you find a solution for this, go ahead and push out a new release.

[tagliala]

@ChiperSoft sure. I just created another branch with a fix.

Maybe when you started Kalendae there was no startOf('day') function in moment.js so you had to write your own one? (stripTime)

@yogendra689 @danhodos @magnars please download the build from timezone-fix branch and check if it's ok for you. Please also check other features (blackout, directions).The index page seems fine

[Twipped]

Yup, that's exactly what happened. That's good, sounds like we can remove some stuff from the moment extensions.

[magnars]

I've pushed a new version of our app with the timezone-fix branch. Will report back.

[tagliala]

@ChiperSoft sorry I'm not being so useful here. Can I merge the timezone-fix branch or it was already merged?

@magnars any issue to report?

[Twipped]

Go ahead and merge it, I think we can assume silence is acceptance.

[magnars]

No complaints after installing this patch.

On 24. okt. 2013, at 16:45, Geremia Taglialatela notifications@github.com wrote:

@ChiperSoft sorry I'm not being so useful here. Can I merge the timezone-fix branch or it was already merged?

@magnars any issue to report?

— Reply to this email directly or view it on GitHub.

[tagliala]

@ChiperSoft merged in my local repository. I think we should bump the version number to 0.5.0 instead of 0.4.2 because of #112 and #111

Can I proceed?

[Twipped]

Sounds good, go ahead.