TwistedGate / ImmersivePetroleum

Oil and oil processing for Immersive Engineering
https://minecraft.curseforge.com/projects/immersive-petroleum
31 stars 31 forks source link

Compat Issue with diagonal fences mod #118

Closed TheKidThatCodes closed 1 year ago

TheKidThatCodes commented 1 year ago

Minecraft Version

1.18.2

Immersive Engineering Version

1.18.2-8.2.2-154

Immersive Petroleum Version

4.0.0-16

Current Behaviour

diagonal fences mod makes it impossible to form the derrick multiblock Screenshot

Expected Behaviour

the multiblock forms and ignores that the fences are diagonal

Reproduction Steps

build derrick try to form it

Debug Crash Log

ByteBin or Crashy

Information for the reader.

TheKidThatCodes commented 1 year ago

the debug stick can be used to fix the issue but that is not survival friendly

TwistedGate commented 1 year ago

Wrong ID.

emanuele246gi commented 1 year ago

I also have this issue

MrMorgan0 commented 1 year ago

Hi @TheKidThatCodes , i find how we can FIX that... i don't know why Fuzs didn't add config file to DiagonalFences mod, but we can fix it in another way. He add the Tag for fences that shouldn't be diagonal, so we should fix that by adding several code lines in that file. If you have installed OpenLoader mod, you also can fix it easily. Follow steps below and it will be fixed.

GAME SHOULD BE CLOSED

  1. Go to your Minecraft directory mods folder,
  2. Find there DiagonalFences-v3.1.0-1.18.2 and open it with WinRAR archiver,
  3. Open folder data>diagonalfences>tags>blocks and there you can find .json file named non_diagonal_fences.json,
  4. Open it and replace this code. Make sure that u have selected all code, jsut press Ctrl + A and Ctrl + V after copy code below:

    {
    "replace": false,
    "values": [
    {
      "id": "assorteddecor:colorizer_fence",
      "required": false
    },
    
    {
      "id": "immersiveengineering:alu_fence",
      "required": false
    },
    
    {
      "id": "immersiveengineering:steel_fence",
      "required": false
    }
    
    ]
    }

    DON'T FORGET TO SAVE THAT FILE Here's result of that 2023-04-29_19 30 01

I hope you did all things right and it help you to fix that issue.. P.S. Close the issue if you haven't any questions ;) P.S.S If u want to fix it with OpenLoader also write here, I'll help you as well

TheKidThatCodes commented 1 year ago

whats winrar?

TheKidThatCodes commented 1 year ago

Hi @TheKidThatCodes , i find how we can FIX that... i don't know why Fuzs didn't add config file to DiagonalFences mod, but we can fix it in another way. He add the Tag for fences that shouldn't be diagonal, so we should fix that by adding several code lines in that file. If you have installed OpenLoader mod, you also can fix it easily. Follow steps below and it will be fixed.

GAME SHOULD BE CLOSED

  1. Go to your Minecraft directory mods folder,
  2. Find there DiagonalFences-v3.1.0-1.18.2 and open it with WinRAR archiver,
  3. Open folder data>diagonalfences>tags>blocks and there you can find .json file named non_diagonal_fences.json,
  4. Open it and replace this code. Make sure that u have selected all code, jsut press Ctrl + A and Ctrl + V after copy code below:
{
  "replace": false,
  "values": [
    {
      "id": "assorteddecor:colorizer_fence",
      "required": false
    },

  {
      "id": "immersiveengineering:alu_fence",
      "required": false
    },

  {
      "id": "immersiveengineering:steel_fence",
      "required": false
    }

  ]
}

DON'T FORGET TO SAVE THAT FILE Here's result of that 2023-04-29_19 30 01

I hope you did all things right and it help you to fix that issue.. P.S. Close the issue if you haven't any questions ;) P.S.S If u want to fix it with OpenLoader also write here, I'll help you as well

this issue is meant for a permanent fix not some hacky patch

MrMorgan0 commented 1 year ago

Winrar just like 7Zip

TheKidThatCodes commented 1 year ago

is there a macos alternative

MrMorgan0 commented 1 year ago

Winrar is just for MacOs too, you can downlaod it here

TheKidThatCodes commented 1 year ago

as i said before, this issue is for a permanent fix, not a hacky patch

MrMorgan0 commented 1 year ago

as i said before, this issue is for a permanent fix, not a hacky patch

It is what it is...

There is two ways in my opinion how to permanent fix it, and you also need to write that on Diagonal Fences issue page.

@TwistedGate Should add non_diagonal_fences tag into the Steel Fence in he's code or Fuzs should add Config file for Diagonal Fences mod, where you can configurate which kind of fences will not able to be diagonal.

TwistedGate commented 1 year ago

Should add non_diagonal_fences tag into the Steel Fence

Steel fences are from Immersive Engineering and not from IP.

And closing because Stale.