TwistedGate / ImmersivePetroleum

Oil and oil processing for Immersive Engineering
https://minecraft.curseforge.com/projects/immersive-petroleum
31 stars 31 forks source link

Oil Tank redstone support not working as expected #155

Closed Sam2451 closed 1 year ago

Sam2451 commented 1 year ago

Minecraft Version

1.18.2

Immersive Engineering Version

8.4.0-161

Immersive Petroleum Version

4.1.0-21

Current Behaviour

Comparator monitoring of the oil tank layes works fine with the redstone probe connector, but vanilla comparators need an update (like budded pistons) to realize the change of the level of liquid in the tank Redston ports do not work, vanilla comparator and the probe connector pick up just the level of the layer.

Expected Behaviour

Vanilla comparators should check and refresh redstone level according to liquid level of the oil tank (layers and redston spot) every game tick or redstone tick. Redstone spot should output the value based on whole oil tank fluid level and not layer fluid level.

Reproduction Steps

Create an oil tank, than hook up a pump on an infinite water source to tank input. Connect vanilla and IE comparators on every layer, a comparator to the side redstone spot and redstone probe connector on upper redstone spot. When water level rises probes on layers work fine, vanilla comparators stay off until updated(replaced, putting in subtract mode, update a block within one Manhattan distance), and comparators on redstone spot just mesure last layer level (vanilla comparator needs update)

Debug Crash Log

https://gist.github.com/Sam2451/bd90ca1b79f1211925208aa7be881dee

Information for the reader.