TwistedGate / ImmersivePetroleum

Oil and oil processing for Immersive Engineering
https://minecraft.curseforge.com/projects/immersive-petroleum
31 stars 31 forks source link

[1.16.5/1.18.2] Recipe warning with kubejs #159

Closed MundM2007 closed 1 year ago

MundM2007 commented 1 year ago

Minecraft Version

1.16.5 / 1.18.2

Immersive Engineering Version

ImmersiveEngineering-1.16.5-5.1.0-148.jar / ImmersiveEngineering-1.18.2-8.4.0-161.jar

Immersive Petroleum Version

ImmersivePetroleum-1.16.5-3.4.0-20.jar / ImmersivePetroleum-1.18.2-4.1.0-21.jar

Current Behaviour

The recipe issue with kubejs described in #31 also appears in 1.18.2. The Recipes still get added and you can add new recipes it just calls this warning I've posted an comment saying the reason for this:

@TwistedGate The reason for this error java.lang.IllegalArgumentException: Unexpected json object seems to be that kubejs doesn't correctly detect the chance in the output item for destillation and hydrotreating, which create this error if the chance is not given. This also applies to adding recipes, which confused me at first, cause this value shouldn't be required. My suggestion would be that you make the chance value optional and default to 1.0.

Also I have a question (which is also in the original comment.): Another question: Why does every fluid input and Coker's output require a tag?

Expected Behaviour

That recipes dont give warnings in kubejs

Reproduction Steps

  1. install kubejs and immersive petroleum
  2. Start the game
  3. See error in kubejs Server Log

Information for the reader.

MundM2007 commented 1 year ago

the debug log if needed debug.log

TwistedGate commented 1 year ago

Should be taken care of by 69f7ddf97f1797bf49e99e3503e32d6a8c9760b8