The Chat type is defined to have a Vec<BoxedChat> as a member (indirectly, through BaseChatComponent type) because originally I thought the indirection was necessary in Vec type. As it turns out, I didn't know Rust all that well when I wrote this code, and I realize now that we don't need the indirection in this case.
I left the BoxedChat alias and the .boxed() method on the Chat type because indirection is required in one case (the only associated value for ChatHoverEvent::ShowText must be a Chat type).
Review Notes:
Are we OK to make this sort of change without bumping to 0.3.0? I don't think this'll break any usages of the library.
The
Chat
type is defined to have aVec<BoxedChat>
as a member (indirectly, throughBaseChatComponent
type) because originally I thought the indirection was necessary inVec
type. As it turns out, I didn't know Rust all that well when I wrote this code, and I realize now that we don't need the indirection in this case.I left the
BoxedChat
alias and the.boxed()
method on theChat
type because indirection is required in one case (the only associated value forChatHoverEvent::ShowText
must be aChat
type).Review Notes: