Feature/configuration - Githubissues

TwisterMc / pdfjs-viewer-shortcode

A Wordpress plugin for embedding PDFs using Mozilla's Excellent PDF.js

https://wordpress.org/plugins/pdfjs-viewer-shortcode/

Apache License 2.0

7 stars 5 forks source link

Feature/configuration #1

Closed JimSchofield closed 4 years ago

JimSchofield commented 4 years ago

Adding eslint that is trying to conform to wordpress linting standards Adding prettier file Removing redundant js file Adding scripts to package.json. To run a build or watch in webpack you can now do npm run build or watch.

TODO:

[ ] Address folder naming issue for when the repo is pulled down?
[x] Address "invalid text domain" linting issue @wordpress/i18n-text-domain: Invalid text domain 'pdf-js-block'

TwisterMc commented 4 years ago

We should ensure your editor is setup to work with WordPress coding standards. Things like aligning equal signs and spaces after open pren and before closing. https://jasonyingling.me/setting-up-wordpress-coding-standards-in-visual-studio-code/

TwisterMc commented 4 years ago

Now that I merged, this, I can't get my gutenberg block to load locally. No errors either.

JimSchofield commented 4 years ago

We should ensure your editor is setup to work with WordPress coding standards. Things like aligning equal signs and spaces after open pren and before closing. https://jasonyingling.me/setting-up-wordpress-coding-standards-in-visual-studio-code/

I was looking through https://developer.wordpress.org/coding-standards/wordpress-coding-standards/javascript/ and I'm a little confused why ESlint from wp core is not enforcing some of these things.