search

TwitchLib / TwitchLib.Api

API component of TwitchLib.
70 stars 84 forks source link

Adding the "Helix_Moderator_Manage_Shoutouts" scope #363

Closed CyberMermaidKometteVT closed 1 year ago

CyberMermaidKometteVT commented 1 year ago

This scope was missing from TwitchLib's latest version, and the TwitchAPI.Helix.Chat.SendShoutoutAsync() call can't succeed without authenticating outside of TwitchLib's authentication process as a result. Per Mahsaap's chat in Discord, this and other scopes were accidentally not committed in one of their previous checkins, so I thought I'd quietly come in and contribute.

Note: this is sort of untested 😅

swiftyspiffy commented 1 year ago

Looking at this PR now (sorry for the very long delay), it looks like a couple things have happened:

  1. The helpers class was refactored to be a little more pretty: https://github.com/TwitchLib/TwitchLib.Api/blob/dev/TwitchLib.Api.Core/Common/Helpers.cs
  2. The mentioned scope has been added.

So it prob doesn't make sense to merge this, but definitely appreciate the contribution. Also as a side note, we should target dev branch for any changes, that way we can do normal release process for master (this is a common mistake for first time contributors, so no worries).

Thanks again! Feel free to leave a comment if you think I missed something.