Brings up to date with Communication changes

TwitchLib / TwitchLib.PubSub

PubSub component of TwitchLib.

38 stars 51 forks source link

Brings up to date with Communication changes #20

Closed prom3theu5 closed 6 years ago

prom3theu5 commented 6 years ago

(No Functionality Changes)

prom3theu5 commented 6 years ago

Just added a new Commit to this. Brings in xUnit tests for both the comms clients, as well as fixes re-connection in both of them :)

RRickkert commented 6 years ago

@prom3theu5 Just noticed that the solution references the Communications.csproj file. Which is good. But it also references the Communications.Tests.csproj. Any particular reason why this was added? To me it seems like a Test project from a completely different repo shouldn't be included in any of the other ones. If the Communications project would be on it's own, as in not a submodule, then I agree it should be added.

Could you give some clarification on this?