search

TwitchLib / TwitchLib.PubSub

PubSub component of TwitchLib.
38 stars 51 forks source link

Update ChannelSubscription #33

Closed vaindil closed 5 years ago

vaindil commented 5 years ago

This adds the new cumulative-months and streak-months properties to ChannelSubscription. They are hyphenated, not snake_case like everything else. (That's how it is in the docs and I also verified manually.)

cumulative-months and streak-months are used only for regular subs/resubs, but the old months field is still used for gifts and anon gifts. I figure int? is the best way to handle that but I'm not sure, let me know. I verified that manually as well, it's not an inconsistency with the docs.

Mahsaap commented 5 years ago

I don't think it will ever be null and the nullable and checks probably arnt required.

vaindil commented 5 years ago

The months field is completely absent for regular subs/resubs, and cumulative-months/streak-months are absent for gifted subs. Wouldn't they be null there?

Mahsaap commented 5 years ago

hmmmm i suppose. ya makes sense then